Summary

The segmentation mode's modeFactory accepts a modeConfiguration argument but never applies it to the returned mode instance. As a result, any modesConfiguration['@ohif/mode-segmentation'] overrides from the app config (such as hide, displayName, routeName, etc.) are silently ignored for this mode.

Other modes (e.g. usAnnotation, tmtv, microscopy, preclinical-4d) already spread ...modeConfiguration into their returned object. This change brings the segmentation mode in line with them.

// platform/app/src/appInit.js
const modeConfiguration =
  appConfig.modesConfiguration && appConfig.modesConfiguration[id]
    ? appConfig.modesConfiguration[id]
    : {};
mode = await mode.modeFactory({ modeConfiguration, loadModules });

Before this fix, e.g. the following config had no effect on the segmentation mode:

modesConfiguration: {
  '@ohif/mode-segmentation': { hide: true },
},

Changes

• Spread ...modeConfiguration into the object returned by the segmentation modeFactory.

Test plan

• Add modesConfiguration: { '@ohif/mode-segmentation': { hide: true } } to the app config and confirm the Segmentation mode no longer appears in the mode selector.
• Confirm overriding displayName for @ohif/mode-segmentation is reflected in the mode selector.
• Confirm default behavior (no override) is unchanged.

Made with Cursor

Summary by CodeRabbit

• Bug Fixes
  • Fixed mode configuration to ensure all provided settings are properly applied when creating mode definitions.

Greptile Summary

This PR fixes a bug where the segmentation mode's modeFactory accepted a modeConfiguration argument but never spread it into the returned mode object, causing any app-config overrides (e.g. hide: true, custom displayName) to be silently ignored.

• Adds ...modeConfiguration at the end of the returned object in modes/segmentation/src/index.tsx, matching the existing pattern used by every other OHIF mode.
• Because the spread is the last entry in the object literal, caller-supplied overrides correctly take precedence over the defaults defined above them.

Confidence Score: 5/5

Safe to merge — a one-line fix that aligns the segmentation mode with the established pattern used by every other mode in the repo.

The change is a single spread operator added at the end of a plain object literal. It defaults to an empty object when no overrides are supplied, so existing behaviour is fully preserved. The same pattern is already in production across multiple other modes.

No files require special attention.

_{Reviews (2): Last reviewed commit: "Merge branch 'master' into fix/segmentat..." | Re-trigger Greptile}